To start a code review, choose one of the following approaches:
If your Helix Server is configured as a commit-edge deployment, and your normal connection is to an edge server, Swarm refuses to start reviews for shelved changes that have not been promoted to the commit server.
Within Swarm, this means that the Request Review button does not appear for unpromoted shelved changes. Outside of Swarm, attempts to start reviews for unpromoted shelved changelists appear to do nothing. Ask your Helix Server administrator for assistance if you cannot start a review.
An administrator of the Helix Server can automatically promote shelved changes to the commit server by setting the configurable dm.shelve.promote
to 1
.
To view a shelved or submitted changelist, use a Quick URL. For example, if your change is 54321, visit the URL: https://myswarm.url/54321
When you are about to shelve or submit files:
Include #review
within your changelist (separated from other text with whitespace, or on a separate line).
Once the review begins, Swarm replaces #review
with #review-12345
, where 12345
is the review's identifier.
The #review
keyword is customizable. For details, see Review keyword.
If your @mention
or @@mention
includes an asterisk (*
) before the userid or groupid, for example @*userid
, that user or all of the group members become required reviewers. If your @@mention
includes an exclamation mark (!
) before the groupid, for example @@!groupid
, the members of that group become required reviewers but only one member of the group is required to vote. See Required reviewers for details.
If you shelve a changelist and subsequently edit the description to include #review
, a review is not started. You must re-shelve the files after adding #review
.
You can also start a Swarm review with P4V, P4VS, and P4Eclipse. See below for details:
When you are using Git FusionA Perforce product that integrates Git with Helix, offering enterprise-ready Git repository management, and workflows that allow Git and Helix Server users to collaborate on the same projects using their preferred tools., you can start a review by pushing your changes to a target branch using the following command:
$ git push origin task1:review/master/new
task1
is the name of the current Git task branch, and master
is the target branch that the proposed changes are intended for.
The target branch must be mapped to a named Helix Server branch in the Git Fusion repo configuration.
See the Converting a lightweight branch into a fully-populated branch section of the Git Fusion Guide for details.
When the command completes, the output indicates the review id
that has been created:
remote: Perforce: Swarm review assigned: review/master/1234
where 1234
is the review id that was just created.
For more information on Git Fusion, see the Git Fusion Guide.
If you are using P4V and its Swarm integration, and you encounter the error Host requires authentication
, ask your Helix Versioning Engine administrator for assistance. See P4V Authentication for details.
Wait for someone else to review your code, or see How do I contribute comments or code changes to a code review? More review activities are available.